feat: remove duplication from TriggerView and EnvTriggerView#2830
Merged
AbhishekA1509 merged 52 commits intodevelopfrom Aug 7, 2025
Merged
feat: remove duplication from TriggerView and EnvTriggerView#2830AbhishekA1509 merged 52 commits intodevelopfrom
AbhishekA1509 merged 52 commits intodevelopfrom
Conversation
…nto fix/trigger-view
- Removed unused properties and methods from TriggerViewContext and TriggerViewState interfaces. - Updated TriggerViewContextType to simplify context management. - Cleaned up CIMaterialState and related interfaces. - Adjusted WorkflowProps to include openCIMaterialModal function. - Modified TriggerCINode to utilize openCIMaterialModal instead of context. - Enhanced processCIMaterialResponse to ensure type safety with CIMaterialType. - Updated getCIMaterialList function parameters for better clarity. - Removed unused route WEBHOOK_RECEIVED_PAYLOAD_ID from routes configuration.
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
github-actions
bot
added
the
PR:Issue-verification-failed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… handling and commit history updates
…l handling and loading states
- Updated the logic to correctly set the `isSelected` property of the material to ensure the correct material state is maintained. - Modified the `setMaterialList` function to set `isMaterialLoading` for the selected material while leaving other properties unchanged, improving the loading state handling during material fetching.
… in BuildImageModal
…onstants in EnvTriggerView
- Refactored GitInfoMaterial to support bulk CI triggering, including handling of multiple applications and their respective states. - Introduced new service functions for triggering builds and managing errors. - Added utility functions for payload generation and validation of materials. - Updated TriggerBuildSidebar to render application-specific materials and cache options. - Implemented new types and interfaces for better type safety and clarity. - Enhanced user experience with informative tooltips and error handling for CI configurations.
…ecks in TriggerBuildSidebar
…ex values and enhance button functionality
…or better user experience
AbhishekA1509
commented
Jul 23, 2025
src/components/app/details/triggerView/BuildImageModal/BuildImageModal.tsx
Show resolved
Hide resolved
… related components
…ror handling and state management
…line state management and improve data fetching with useQuery
vivek-devtron
previously approved these changes
Aug 1, 2025
refactor: ConfigMapSecret and EnvironmentOverride components - streamline state management and improve data fetching with useQuery
chore: focus trap and misc fixes
fix: pick status for linked ci similar to ci node
chore: update common-lib version
feat: add cluster status cell from fe-lib
chore: common-lib version bump
chore: add copyright text
chore: merge rc-v0.41.0
…nto fix/trigger-view
… fix/trigger-view
AbhishekA1509
dismissed stale reviews from vivek-devtron and RohitRaj011
via
6926117
…-1 in package.json and yarn.lock
|
vivek-devtron
approved these changes
Aug 7, 2025
RohitRaj011
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2440
Type of change
How Has This Been Tested?
QA
Checklist: